From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH 9 of 9] Modify all call sites of queries into the p2m to use the new fine-grained locking Date: Thu, 27 Oct 2011 16:02:07 +0100 Message-ID: <20111027150207.GO59656@ocelot.phlegethon.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andres Lagar-Cavilla Cc: andres@gridcentric.ca, xen-devel@lists.xensource.com, olaf@aepfle.de, keir.xen@gmail.com, adin@gridcentric.ca List-Id: xen-devel@lists.xenproject.org At 00:33 -0400 on 27 Oct (1319675634), Andres Lagar-Cavilla wrote: > 28 files changed, 519 insertions(+), 101 deletions(-) And I thought patch 5 was big :) I'm not going to read the detail of this this time around - I'd like to only have to review it once. :) I wonder whether it would be worth changing the name/signature of the generic p2m functions in an incompatime way while we're there. It would have three advantages: - allow the lookup/drop pairs to have nice matching names - get rid of the confusingly-named 'gmfn_to_mfn' function - avoid later bugs if patches are forward-ported across this chaneg that add p2m lookups (but not corresoponding drops) Tim.