From: Rabin Vincent <rabin@rab.in>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Jason Baron <jbaron@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] x86: call stop_machine_text_poke() on all CPUs
Date: Fri, 28 Oct 2011 18:00:02 +0530 [thread overview]
Message-ID: <20111028123002.GA3012@debian> (raw)
In-Reply-To: <4EAA1357.8060802@hitachi.com>
On Fri, Oct 28, 2011 at 11:28:39AM +0900, Masami Hiramatsu wrote:
> (2011/10/27 16:54), Rabin Vincent wrote:
> > It appears that stop_machine_text_poke() wants to be called on all CPUs,
> > like it's done from text_poke_smp(). Fix text_poke_smp_batch() to do
> > this.
>
> cpu_mask==NULL finally falls back to cpu_online_mask, but even though
> it should be specified correctly.
Not quite. Passing NULL to __stop_machine means that the function will
be called on any one CPU only, while passing cpu_online_mask means that
the function will be called on all CPUs. So this patch is a behaviour
change/bug fix, not just a clarification.
next prev parent reply other threads:[~2011-10-28 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 7:54 [PATCH] x86: call stop_machine_text_poke() on all CPUs Rabin Vincent
2011-10-28 2:28 ` Masami Hiramatsu
2011-10-28 12:30 ` Rabin Vincent [this message]
2011-11-01 12:04 ` Masami Hiramatsu
2011-11-18 23:35 ` [tip:x86/urgent] x86: Call " tip-bot for Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028123002.GA3012@debian \
--to=rabin@rab.in \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.