From: Andrew Morton <akpm@linux-foundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: [PATCH] ida: make ida_simple_get/put() IRQ safe
Date: Fri, 28 Oct 2011 16:16:38 -0700 [thread overview]
Message-ID: <20111028161638.125099fe.akpm@linux-foundation.org> (raw)
In-Reply-To: <20111028231149.GA31997@google.com>
On Fri, 28 Oct 2011 16:11:49 -0700
Tejun Heo <tj@kernel.org> wrote:
> On Fri, Oct 28, 2011 at 04:01:15PM -0700, Andrew Morton wrote:
> > On Wed, 26 Oct 2011 13:33:11 -0700
> > Tejun Heo <tj@kernel.org> wrote:
> >
> > > It's often convenient to be able to release resource from IRQ context.
> > > Make ida_simple_*() use irqsave/restore spin ops so that they are IRQ
> > > safe.
> >
> > The patch also accidentally makes ida_simple_get() callable from
> > interrupt context. That's a somewhat unreliable operation due to
> > -ENOMEM possibilities even with GFP_ATOMIC.
>
> Hmmm... We can add a WARN_ON_ONCE() there but do we really care? If
> the caller is using GFP_ATOMIC, it should be expecting unreliability.
>
No, I don't think we care - I was just chin-scratching and augmenting
some deficient changeloggery. Also, showing that I'd actually read the
thing ;)
prev parent reply other threads:[~2011-10-28 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 20:33 [PATCH] ida: make ida_simple_get/put() IRQ safe Tejun Heo
2011-10-28 23:01 ` Andrew Morton
2011-10-28 23:11 ` Tejun Heo
2011-10-28 23:16 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028161638.125099fe.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.