From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Paul Schilling <paul.s.schilling@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
"David S. Miller" <davem@davemloft.net>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug.
Date: Fri, 28 Oct 2011 19:27:10 +0100 [thread overview]
Message-ID: <20111028192710.361093ea@pyx> (raw)
In-Reply-To: <CAC=G6sz9tpLnxWN7_Ts+rcNf-YQZw-4VQUNo6vKNeHOnOPOHVA@mail.gmail.com>
On Thu, 27 Oct 2011 13:55:21 -0500
Paul Schilling <paul.s.schilling@gmail.com> wrote:
> The Vortex86dx uses RDC IDE peripheral integrated into the SOC. The
> CRC design is
> broken in the Vortex86dx and sx. The original reference can be found
> in the Linux kernel itself.
>
> The Vortex86sx uses the RDC D1010.
> The Vortex86dx uses the RDC D1011.
> Both of which have broken CRC hardware which breaks DMA.
CRC hardware is only used for *UDMA* yet your change also disabled MWDMA.
> >> static const struct ata_port_info info_rdc_11 = {
> >> .flags = ATA_FLAG_SLAVE_POSS,
> >> .pio_mask = ATA_PIO4,
> >> - .mwdma_mask = ATA_MWDMA2,
> >> + .mwdma_mask = 0,
> >> + .udma_mask = 0,
Why ?
next prev parent reply other threads:[~2011-10-28 18:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fix vortex86>
2011-10-23 5:05 ` [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug Paul Schilling
2011-10-23 5:05 ` Paul Schilling
2011-10-23 8:20 ` Rolf Eike Beer
2011-10-23 16:26 ` Paul Schilling
2011-10-26 4:16 ` Paul Schilling
2011-10-26 4:16 ` Paul Schilling
2011-10-27 7:43 ` Alan Cox
2011-10-27 18:55 ` Paul Schilling
2011-10-27 19:03 ` Paul Schilling
2011-10-28 18:27 ` Alan Cox [this message]
2011-10-31 19:07 ` Paul Schilling
2011-11-01 1:02 ` Alan Cox
2011-11-03 22:58 ` Paul Schilling
2011-11-03 23:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028192710.361093ea@pyx \
--to=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=paul.s.schilling@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.