All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	John Baboval <john.baboval@virtualcomputer.com>
Subject: Re: [Qemu-devel] [PATCH] IDE Debug compiler warnings
Date: Sat, 29 Oct 2011 01:15:51 +0400	[thread overview]
Message-ID: <201110290115.52514.jcmvbkbc@gmail.com> (raw)
In-Reply-To: <CAFEAcA-ZRZ9F6CvLb=Lbd=2q7M6ygArp9qo_p24L-ohbqL_j9w@mail.gmail.com>

> > --- a/hw/ide/ahci.c
> > +++ b/hw/ide/ahci.c
> > @@ -327,7 +327,7 @@ static void ahci_mem_write(void *opaque,
> > target_phys_addr_t addr,
> >     }
> >      if (addr < AHCI_GENERIC_HOST_CONTROL_REGS_MAX_ADDR) {
> > -        DPRINTF(-1, "(addr 0x%08X), val 0x%08X\n", (unsigned) addr, val);
> > +        DPRINTF(-1, "(addr 0x%08X), val 0x%08lX\n", (unsigned) addr, val);
> 
> val is uint64_t so you need to use PRIx64 (otherwise you
> get warnings on either 32 bit or 64 bit hosts depending
> on whether you use %x or %lx).

This and other ahci format strings fixes are already in the queue: http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg03178.html

Thanks.
-- Max

      reply	other threads:[~2011-10-28 21:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28 19:39 [Qemu-devel] [PATCH] IDE Debug compiler warnings John Baboval
2011-10-28 20:47 ` Peter Maydell
2011-10-28 21:15   ` Max Filippov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110290115.52514.jcmvbkbc@gmail.com \
    --to=jcmvbkbc@gmail.com \
    --cc=john.baboval@virtualcomputer.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.