From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45093)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1RJtmV-0002A5-4X
	for qemu-devel@nongnu.org; Fri, 28 Oct 2011 17:16:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1RJtmT-0004Os-VC
	for qemu-devel@nongnu.org; Fri, 28 Oct 2011 17:16:03 -0400
Received: from mail-bw0-f45.google.com ([209.85.214.45]:61253)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1RJtmT-0004Ok-Na
	for qemu-devel@nongnu.org; Fri, 28 Oct 2011 17:16:01 -0400
Received: by bke5 with SMTP id 5so739966bke.4
	for <qemu-devel@nongnu.org>; Fri, 28 Oct 2011 14:16:00 -0700 (PDT)
From: Max Filippov <jcmvbkbc@gmail.com>
Date: Sat, 29 Oct 2011 01:15:51 +0400
References: <4EAB04EF.3080208@virtualcomputer.com>
	<CAFEAcA-ZRZ9F6CvLb=Lbd=2q7M6ygArp9qo_p24L-ohbqL_j9w@mail.gmail.com>
In-Reply-To: <CAFEAcA-ZRZ9F6CvLb=Lbd=2q7M6ygArp9qo_p24L-ohbqL_j9w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201110290115.52514.jcmvbkbc@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] IDE Debug compiler warnings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, John Baboval <john.baboval@virtualcomputer.com>

> > --- a/hw/ide/ahci.c
> > +++ b/hw/ide/ahci.c
> > @@ -327,7 +327,7 @@ static void ahci_mem_write(void *opaque,
> > target_phys_addr_t addr,
> >     }
> >      if (addr < AHCI_GENERIC_HOST_CONTROL_REGS_MAX_ADDR) {
> > -        DPRINTF(-1, "(addr 0x%08X), val 0x%08X\n", (unsigned) addr, val);
> > +        DPRINTF(-1, "(addr 0x%08X), val 0x%08lX\n", (unsigned) addr, val);
> 
> val is uint64_t so you need to use PRIx64 (otherwise you
> get warnings on either 32 bit or 64 bit hosts depending
> on whether you use %x or %lx).

This and other ahci format strings fixes are already in the queue: http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg03178.html

Thanks.
-- Max