All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Hans J. Koch" <hjk@hansjkoch.de>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 1/2] uio: allow drivers to override the pgprot for mmap
Date: Sat, 29 Oct 2011 08:38:09 +0200	[thread overview]
Message-ID: <20111029063809.GC2280@kroah.com> (raw)
In-Reply-To: <20111028214812.GD23092@local>

On Fri, Oct 28, 2011 at 11:48:12PM +0200, Hans J. Koch wrote:
> On Fri, Oct 28, 2011 at 10:50:29AM -0500, Kumar Gala wrote:
> > For some devices, the default behavior of pgprot_noncached() is not
> > appropriate for all of its mappable regions. This provides a means for
> > the kernel side of the UIO driver to override the flags without having
> > to implement its own full mmap callback.
> 
> Thanks for also providing an example driver showing the use of this.
> You should also post this driver in a mainline-ready version, I'm a bit
> uncomfortable with adding a new function pointer without having any users.

I'm more than "uncomfortable", I'll refuse to take any such patch unless
there is a in-kernel user, otherwise it makes no sense to add the
pointer at all.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: "Hans J. Koch" <hjk@hansjkoch.de>
Cc: Kumar Gala <galak@kernel.crashing.org>,
	linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 1/2] uio: allow drivers to override the pgprot for mmap
Date: Sat, 29 Oct 2011 08:38:09 +0200	[thread overview]
Message-ID: <20111029063809.GC2280@kroah.com> (raw)
In-Reply-To: <20111028214812.GD23092@local>

On Fri, Oct 28, 2011 at 11:48:12PM +0200, Hans J. Koch wrote:
> On Fri, Oct 28, 2011 at 10:50:29AM -0500, Kumar Gala wrote:
> > For some devices, the default behavior of pgprot_noncached() is not
> > appropriate for all of its mappable regions. This provides a means for
> > the kernel side of the UIO driver to override the flags without having
> > to implement its own full mmap callback.
> 
> Thanks for also providing an example driver showing the use of this.
> You should also post this driver in a mainline-ready version, I'm a bit
> uncomfortable with adding a new function pointer without having any users.

I'm more than "uncomfortable", I'll refuse to take any such patch unless
there is a in-kernel user, otherwise it makes no sense to add the
pointer at all.

thanks,

greg k-h

  reply	other threads:[~2011-10-29  6:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28 15:50 [RFC][PATCH 1/2] uio: allow drivers to override the pgprot for mmap Kumar Gala
2011-10-28 15:50 ` Kumar Gala
2011-10-28 15:50 ` [RFC][PATCH 2/2] Example to show use of uio pgprot Kumar Gala
2011-10-28 15:50   ` Kumar Gala
2011-10-28 16:37   ` Greg KH
2011-10-28 16:37     ` Greg KH
2011-10-28 17:52     ` Kumar Gala
2011-10-28 17:52       ` Kumar Gala
2011-10-28 21:40   ` Hans J. Koch
2011-10-28 21:40     ` Hans J. Koch
2011-10-28 21:48 ` [RFC][PATCH 1/2] uio: allow drivers to override the pgprot for mmap Hans J. Koch
2011-10-28 21:48   ` Hans J. Koch
2011-10-29  6:38   ` Greg KH [this message]
2011-10-29  6:38     ` Greg KH
2011-10-31 13:44     ` Kumar Gala
2011-10-31 13:44       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111029063809.GC2280@kroah.com \
    --to=greg@kroah.com \
    --cc=hjk@hansjkoch.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.