From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mark empty gpio.h files empty
Date: Sat, 29 Oct 2011 13:06:13 +0200 [thread overview]
Message-ID: <20111029110613.GE20132@ponder.secretlab.ca> (raw)
In-Reply-To: <1319833142-4764-1-git-send-email-linus.walleij@linaro.org>
On Fri, Oct 28, 2011 at 10:19:02PM +0200, Linus Walleij wrote:
> It is generally a better idea to make intentionally empty files
> contain the human-readable /* empty */ comment, also it makes
> the files play nice with "make distclean".
>
> Reported-by: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thanks.
g.
> ---
> arch/arm/mach-lpc32xx/include/mach/gpio.h | 1 +
> arch/arm/mach-tegra/include/mach/gpio.h | 1 +
> arch/arm/mach-u300/include/mach/gpio.h | 1 +
> 3 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-lpc32xx/include/mach/gpio.h b/arch/arm/mach-lpc32xx/include/mach/gpio.h
> index e69de29..40a8c17 100644
> --- a/arch/arm/mach-lpc32xx/include/mach/gpio.h
> +++ b/arch/arm/mach-lpc32xx/include/mach/gpio.h
> @@ -0,0 +1 @@
> +/* empty */
> diff --git a/arch/arm/mach-tegra/include/mach/gpio.h b/arch/arm/mach-tegra/include/mach/gpio.h
> index e69de29..40a8c17 100644
> --- a/arch/arm/mach-tegra/include/mach/gpio.h
> +++ b/arch/arm/mach-tegra/include/mach/gpio.h
> @@ -0,0 +1 @@
> +/* empty */
> diff --git a/arch/arm/mach-u300/include/mach/gpio.h b/arch/arm/mach-u300/include/mach/gpio.h
> index e69de29..40a8c17 100644
> --- a/arch/arm/mach-u300/include/mach/gpio.h
> +++ b/arch/arm/mach-u300/include/mach/gpio.h
> @@ -0,0 +1 @@
> +/* empty */
> --
> 1.7.3.2
>
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
Jeff Garzik <jeff@garzik.org>,
linux-kernel@vger.kernel.org, swarren@nvidia.com, olof@lixom.net,
ben@decadent.org.uk, arnaud.patard@rtp-net.org,
w.sang@pengutronix.de, bs14@csr.com
Subject: Re: [PATCH] ARM: mark empty gpio.h files empty
Date: Sat, 29 Oct 2011 13:06:13 +0200 [thread overview]
Message-ID: <20111029110613.GE20132@ponder.secretlab.ca> (raw)
In-Reply-To: <1319833142-4764-1-git-send-email-linus.walleij@linaro.org>
On Fri, Oct 28, 2011 at 10:19:02PM +0200, Linus Walleij wrote:
> It is generally a better idea to make intentionally empty files
> contain the human-readable /* empty */ comment, also it makes
> the files play nice with "make distclean".
>
> Reported-by: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thanks.
g.
> ---
> arch/arm/mach-lpc32xx/include/mach/gpio.h | 1 +
> arch/arm/mach-tegra/include/mach/gpio.h | 1 +
> arch/arm/mach-u300/include/mach/gpio.h | 1 +
> 3 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-lpc32xx/include/mach/gpio.h b/arch/arm/mach-lpc32xx/include/mach/gpio.h
> index e69de29..40a8c17 100644
> --- a/arch/arm/mach-lpc32xx/include/mach/gpio.h
> +++ b/arch/arm/mach-lpc32xx/include/mach/gpio.h
> @@ -0,0 +1 @@
> +/* empty */
> diff --git a/arch/arm/mach-tegra/include/mach/gpio.h b/arch/arm/mach-tegra/include/mach/gpio.h
> index e69de29..40a8c17 100644
> --- a/arch/arm/mach-tegra/include/mach/gpio.h
> +++ b/arch/arm/mach-tegra/include/mach/gpio.h
> @@ -0,0 +1 @@
> +/* empty */
> diff --git a/arch/arm/mach-u300/include/mach/gpio.h b/arch/arm/mach-u300/include/mach/gpio.h
> index e69de29..40a8c17 100644
> --- a/arch/arm/mach-u300/include/mach/gpio.h
> +++ b/arch/arm/mach-u300/include/mach/gpio.h
> @@ -0,0 +1 @@
> +/* empty */
> --
> 1.7.3.2
>
next prev parent reply other threads:[~2011-10-29 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 20:19 [PATCH] ARM: mark empty gpio.h files empty Linus Walleij
2011-10-28 20:19 ` Linus Walleij
2011-10-28 20:36 ` Jeff Garzik
2011-10-28 20:36 ` Jeff Garzik
2011-10-29 11:06 ` Grant Likely [this message]
2011-10-29 11:06 ` Grant Likely
2011-10-31 15:50 ` Linus Walleij
2011-10-31 15:50 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111029110613.GE20132@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.