From: Steffen Klassert <steffen.klassert@secunet.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: xfrm: Assign the inner mode output function to the dst
Date: Sat, 29 Oct 2011 12:19:00 +0000 [thread overview]
Message-ID: <20111029121900.GA8707@secunet.com> (raw)
In-Reply-To: <20111028151822.GA12707@elgon.mountain>
Hi.
On Fri, Oct 28, 2011 at 06:18:24PM +0300, Dan Carpenter wrote:
> [ Hi. Smatch is complaining about a really old patch here. Sorry
> for that. I will fix it to detect better which warnings are new
> but I saw that there was some work done in this function recently
> so I decided to send this email anyway. --dan ]
>
> Hello Steffen Klassert,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 43a4dea4c9d4: "xfrm: Assign the inner mode output function
> to the dst entry" from May 9, 2011, leads to the following Smatch
> complaint:
>
> net/ipv6/xfrm6_output.c +154 __xfrm6_output()
> error: we previously assumed 'x' could be null (see line 149)
>
> net/ipv6/xfrm6_output.c
> 148
> 149 if ((x && x->props.mode = XFRM_MODE_TUNNEL) &&
> ^
x can't be null here. It would be a bug if __xfrm6_output() is called without
a xfrm_state attached to the skb. I think we can just remove this null check.
prev parent reply other threads:[~2011-10-29 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 15:18 xfrm: Assign the inner mode output function to the dst Dan Carpenter
2011-10-29 12:19 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111029121900.GA8707@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.