All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-nfs@vger.kernel.org,
	Trond Myklebust <Trond.Myklebust@netapp.com>,
	Chuck Lever <chuck.lever@oracle.com>
Subject: Re: nfsd4_is_junction
Date: Sat, 29 Oct 2011 13:45:33 -0400	[thread overview]
Message-ID: <20111029174533.GA12122@fieldses.org> (raw)
In-Reply-To: <20111029101649.GA12345@infradead.org>

On Sat, Oct 29, 2011 at 06:16:49AM -0400, Christoph Hellwig wrote:
> This function should probably grow a check for S_NOSEC instead of
> hitting the filesystems with an xattr read for every lookup.

Note it also takes the convention that junctions should have the sticky
bit set without being executable, and it does those checks before
checking for the xattr, so it shouldn't be doing an xattr read for every
lookup.

Grepping for S_NOSEC.... "no suid or xattr security attributes".  But
"junction.type" isn't a "security attribute", is it?  I may not
understand what that means.

--b.

  reply	other threads:[~2011-10-29 17:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-29 10:16 nfsd4_is_junction Christoph Hellwig
2011-10-29 17:45 ` J. Bruce Fields [this message]
2011-11-02  8:30   ` nfsd4_is_junction Christoph Hellwig
2011-10-29 17:47 ` nfsd4_is_junction Chuck Lever
2011-10-29 17:55   ` nfsd4_is_junction J. Bruce Fields
2011-10-29 17:58     ` nfsd4_is_junction Chuck Lever
2011-10-29 18:09       ` nfsd4_is_junction J. Bruce Fields
2011-10-29 18:38         ` nfsd4_is_junction Chuck Lever
2011-10-29 23:36           ` nfsd4_is_junction Trond Myklebust
2011-10-31 15:09             ` nfsd4_is_junction Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111029174533.GA12122@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=Trond.Myklebust@netapp.com \
    --cc=chuck.lever@oracle.com \
    --cc=hch@infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.