Re: [GIT] CIFS Fixes

["J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>]

On Fri, Oct 28, 2011 at 10:16:58AM -0500, Steve French wrote:
> Be fair to Pavel ... I trivially found individual smb2 patches on list as
> far back as February (probably earlier on the other mailing list),
> the stats patch I redid to include Christoph's feedback and Pavel
> incorporated much feedback this summer from at least four developers
> and from the two test events I attended.

Well, obviously "Here are some comments on this patch" shouldn't be
assumed to mean "consider this patch ACKed if this comments are
addressed".

The policy I aim for (though no doubt I screw it up) is: every patch I
commit should have previously been cc:'d to the appropriate places, in
the form it's applied (eh, modulo whitespace fixes or fixups nearly that
trivial).  And some time should pass before committing.  (Totally
trivial stuff I figure I can get away with committing immediately,
stuff I don't expect much argument over might sit only 24 hours,
anything big I try to make sure potential reviewers have a few days to
respond.)

> And with him breaking the patches into smaller pieces,
> I can see why he was reluctant to post a 50 patch series,
> but posted a link to them.

Another approach is to break up the 50 patches into logical subsets
(especially good is if you can split out any of them as cleanup or
bugfixes that can be justified entirely on their own).

--b.