From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin Slusarz Subject: Re: "enable ctxprog xfer only when we need it to save power" introduces big performance regression Date: Sat, 29 Oct 2011 21:09:38 +0200 Message-ID: <20111029190938.GA3105@joi.lan> References: <20111029170801.GA3219@joi.lan> <20111029172923.GA3110@joi.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20111029172923.GA3110-OI9uyE9O0yo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Martin Peres Cc: Ben Skeggs List-Id: nouveau.vger.kernel.org On Sat, Oct 29, 2011 at 07:29:23PM +0200, Marcin Slusarz wrote: > On Sat, Oct 29, 2011 at 07:08:01PM +0200, Marcin Slusarz wrote: > > Hi > > > > I've bisected pretty big performance regression (nv92): > > > > $ git bisect good > > b2737681d5442f05ab6419e05468c3d2511a5ced is the first bad commit > > commit b2737681d5442f05ab6419e05468c3d2511a5ced > > Author: Martin Peres > > Date: Sat Jul 30 23:08:45 2011 +0200 > > > > drm/nv50/gr: enable ctxprog xfer only when we need it to save power > > Weird, reverting it on top of current git does not restore it - in > glxgears it's even worse (-~50%). It seems "drm/nv50/gr: refactor initialisation" relies on the above. So, reverting these commits: drm/nv50/gr: typo fix, how about we not reset fifo during graph init? drm/nv50/gr: refactor initialisation drm/nv50/gr: enable ctxprog xfer only when we need it to save power on top of current git restores performance to the previous state. (First commit fixes bug in 2nd, so it needs to be reverted first) Marcin