All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] drivers/rtc/ds1337.c: fix GCC 4.6 build warnings
Date: Sun, 30 Oct 2011 00:39:59 +0200	[thread overview]
Message-ID: <201110300039.59309.marek.vasut@gmail.com> (raw)
In-Reply-To: <1319917151-14369-1-git-send-email-wd@denx.de>

> Fix:
> ds1337.c: In function 'rtc_get':
> ds1337.c:88:52: warning: variable 'control' set but not used
> [-Wunused-but-set-variable]
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> ---
>  drivers/rtc/ds1337.c |   16 +++-------------
>  1 files changed, 3 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/rtc/ds1337.c b/drivers/rtc/ds1337.c
> index 7abf041..5bb9f94 100644
> --- a/drivers/rtc/ds1337.c
> +++ b/drivers/rtc/ds1337.c
> @@ -34,16 +34,6 @@
> 
>  #if defined(CONFIG_CMD_DATE)
> 
> -/*---------------------------------------------------------------------*/
> -#undef DEBUG_RTC
> -
> -#ifdef DEBUG_RTC
> -#define DEBUGR(fmt,args...) printf(fmt ,##args)
> -#else
> -#define DEBUGR(fmt,args...)
> -#endif
> -/*---------------------------------------------------------------------*/
> -

This undermines the ability of fine-grained debuging output, right? Now you can 
only debug whole uboot or nothing ... correct me if I'm wrong please.

>  /*
>   * RTC register addresses
>   */
> @@ -97,7 +87,7 @@ int rtc_get (struct rtc_time *tmp)
>  	mon_cent = rtc_read (RTC_MON_REG_ADDR);
>  	year = rtc_read (RTC_YR_REG_ADDR);
> 
> -	DEBUGR ("Get RTC year: %02x mon/cent: %02x mday: %02x wday: %02x "
> +	debug("Get RTC year: %02x mon/cent: %02x mday: %02x wday: %02x "
>  		"hr: %02x min: %02x sec: %02x control: %02x status: %02x\n",
>  		year, mon_cent, mday, wday, hour, min, sec, control, status);
> 

Cheers

  reply	other threads:[~2011-10-29 22:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-29 19:39 [U-Boot] [PATCH] drivers/rtc/ds1337.c: fix GCC 4.6 build warnings Wolfgang Denk
2011-10-29 22:39 ` Marek Vasut [this message]
2011-10-30 13:11   ` Wolfgang Denk
2011-10-30 20:12     ` Marek Vasut
2011-11-03 19:41 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110300039.59309.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.