From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915: Fix recursive calls to unmap
Date: Mon, 31 Oct 2011 08:45:53 +0100 [thread overview]
Message-ID: <20111031074553.GB2920@phenom.ffwll.local> (raw)
In-Reply-To: <1320031005-8729-1-git-send-email-ben@bwidawsk.net>
On Sun, Oct 30, 2011 at 08:16:45PM -0700, Ben Widawsky wrote:
[snip]
> -int
> -i915_gpu_idle(struct drm_device *dev)
> +int i915_gem_gpu_idle(struct drm_device *dev, bool strictly_idle)
> {
> drm_i915_private_t *dev_priv = dev->dev_private;
> int ret, i;
>
> /* Flush everything onto the inactive list. */
> for (i = 0; i < I915_NUM_RINGS; i++) {
> - ret = i915_ring_idle(&dev_priv->ring[i]);
> + ret = i915_ring_idle(&dev_priv->ring[i], strictly_idle);
One bikeshed: When introducing a new parametere all over the tree, I
prefere consistent naming for it, i.e. s/strictly_idle/defer_retirement/
...
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-10-31 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 3:16 [PATCH v3] drm/i915: Fix recursive calls to unmap Ben Widawsky
2011-10-31 7:45 ` Daniel Vetter [this message]
2011-11-02 19:29 ` Dave Airlie
2011-11-03 4:47 ` Ben Widawsky
2011-11-03 20:19 ` Dave Airlie
2011-11-03 22:23 ` Ben Widawsky
2012-01-17 11:15 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031074553.GB2920@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.