From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
To: u-boot@lists.denx.de
Subject: [U-Boot] Conflicting definitions of flush_dcache
Date: Mon, 31 Oct 2011 09:56:25 +0200 [thread overview]
Message-ID: <20111031075624.GA9871@chokladfabriken.org> (raw)
Hi,
I noticed the following dilemma when I tried to enable both
CONFIG_ETHOC and CONFIG_CMD_CACHE:
The ethoc ethernet driver expects:
void flush_dcache(unsigned long start, unsigned long size)
while cmd_cache.c expect it to be:
void flush_dcache(void)
Grepping around the sources, I found that apart from drivers/net/ethoc.c
also drivers/net/altera_tse.c uses flush_dcache with the two ulong parameters.
No architecture apart from nios2 seems to provide flush_dcache like this
and flush_dcache is not declared in common.h,
so my gut feeling is that nios2 and the 2 ethernet drivers should be
changed to use for example flush_dcache_range(?)
Perhaps cmd_cache.c should also be fixed to use flush_dcache_all()?
flush_icache() ofcourse suffer from the same problem.
Stefan
next reply other threads:[~2011-10-31 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 7:56 Stefan Kristiansson [this message]
2011-10-31 18:32 ` [U-Boot] Conflicting definitions of flush_dcache Mike Frysinger
2011-11-01 2:01 ` Thomas Chou
2011-11-01 4:21 ` [U-Boot] [PATCH] cmd_cache: use cache/invalidate functions available in common.h Stefan Kristiansson
2011-11-01 15:17 ` Mike Frysinger
2012-03-06 21:13 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031075624.GA9871@chokladfabriken.org \
--to=stefan.kristiansson@saunalahti.fi \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.