All of lore.kernel.org
 help / color / mirror / Atom feed
From: prajnoha@sourceware.org <prajnoha@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW_DM scripts/dm_event_systemd_r ...
Date: 31 Oct 2011 12:22:51 -0000	[thread overview]
Message-ID: <20111031122251.20828.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	prajnoha at sourceware.org	2011-10-31 12:22:50

Modified files:
	.              : WHATS_NEW_DM 
	scripts        : dm_event_systemd_red_hat.service.in 

Log message:
	Add "ExecReload" to dm-event.service for systemd to reload dmeventd properly.
	
	Normally, restart simply means "stop and start" for systemd. However, if
	we're installing new versions of the dmeventd binary/libdevmapper, we need
	to restart dmeventd. This fails if we have some devices monitored - we need
	to call "dmeventd -R" instead.
	
	The "ExecReload" did not work quite well in some old versions of systemd,
	systemd assumed that only the configuration is reloaded on "ExecReload",
	not the whole binary itself so it lost track of dmeventd daemon (it lost new
	dmeventd PID). This is fixed and seems to be working fine now with recent
	versions of dmeventd.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.519&r2=1.520
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/scripts/dm_event_systemd_red_hat.service.in.diff?cvsroot=lvm2&r1=1.1&r2=1.2

--- LVM2/WHATS_NEW_DM	2011/10/28 20:06:49	1.519
+++ LVM2/WHATS_NEW_DM	2011/10/31 12:22:49	1.520
@@ -1,5 +1,6 @@
 Version 1.02.68 -
 ==================================
+  Add ExecReload to dm-event.service for systemd to reload dmeventd properly.
   Add dm_config_tree_find_str_allow_empty.
   Fix compile-time pool memory locking with DEBUG_MEM.
   Fix valgrind error reports in free of pool chunks with DEBUG_MEM.
--- LVM2/scripts/dm_event_systemd_red_hat.service.in	2011/07/28 12:54:28	1.1
+++ LVM2/scripts/dm_event_systemd_red_hat.service.in	2011/10/31 12:22:50	1.2
@@ -7,6 +7,7 @@
 [Service]
 Type=forking
 ExecStart=@sbindir@/dmeventd
+ExecReload=@sbindir@/dmeventd -R
 PIDFile=@DMEVENTD_PIDFILE@
 OOMScoreAdjust=-1000
 



             reply	other threads:[~2011-10-31 12:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 12:22 prajnoha [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-07-28 12:54 LVM2 ./WHATS_NEW_DM scripts/dm_event_systemd_r prajnoha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111031122251.20828.qmail@sourceware.org \
    --to=prajnoha@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.