From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: wm8711: Add proper mask for wm8711_set_dai_fmt
Date: Mon, 31 Oct 2011 12:37:50 +0000 [thread overview]
Message-ID: <20111031123749.GA10217@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1319771527.3944.4.camel@phoenix>
On Fri, Oct 28, 2011 at 11:12:07AM +0800, Axel Lin wrote:
> Add mask for BIT[3:2] (the Input Audio Data Bit Length Select)
> of WM8711_IFACE(07h) register.
> Otherwise, BIT[3:2] will be always set to 0b00 here.
Your changelog here isn't terribly clear and doesn't really correspond
to the change well. Here you say you're masking something but...
> - u16 iface = 0;
> + u16 iface = snd_soc_read(codec, WM8711_IFACE) & 0x000c;
...what you're actually doing is preserving the existing values of some
register bits. Nevertheless the change looks good so applied.
next prev parent reply other threads:[~2011-10-31 12:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 3:08 [PATCH 1/2] ASoC: wm8711: Fix wrong mask for setting input audio data bit length select Axel Lin
2011-10-28 3:08 ` Axel Lin
2011-10-28 3:12 ` [PATCH 2/2] ASoC: wm8711: Add proper mask for wm8711_set_dai_fmt Axel Lin
2011-10-28 3:12 ` Axel Lin
2011-10-28 7:15 ` Axel Lin
2011-10-31 12:37 ` Mark Brown [this message]
2011-10-28 7:17 ` [PATCH 2/2] ASoC: Leave input audio data bit length settings untouched in wm8711_set_dai_fmt Axel Lin
2011-10-28 7:17 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031123749.GA10217@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.