From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: Lock in the ironlake_panel_vdd_work() Date: Mon, 31 Oct 2011 14:34:46 +0100 Message-ID: <20111031133446.GE2920@phenom.ffwll.local> References: <20111031130133.GJ50300@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DB8B9E710 for ; Mon, 31 Oct 2011 06:33:50 -0700 (PDT) Received: by wyf28 with SMTP id 28so768531wyf.36 for ; Mon, 31 Oct 2011 06:33:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20111031130133.GJ50300@deviant.kiev.zoral.com.ua> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Konstantin Belousov Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Oct 31, 2011 at 03:01:33PM +0200, Konstantin Belousov wrote: > I have a question about ironlake_panel_vdd_work(). Should it use > the device struct_mutex, or need it to be the mode_config.mutex > instead ? Yeah. This was actually flagged in review by Chris and me, but seems to have been lost in the merge. Keith? -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48