All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] max1111 doesn't implement the standard sysfs interface
Date: Mon, 31 Oct 2011 13:18:14 +0000	[thread overview]
Message-ID: <20111031141814.79b5aa69@endymion.delvare> (raw)
In-Reply-To: <20111031141642.0ed2ccc1@endymion.delvare>

Hi Eric,

It was pointed to me that the max1111 driver doesn't implement the
standard sysfs interface for hwmon drivers (as described in
Documentation/hwmon/sysfs-interface). It exports files adc[0-3]_in, which
aren't part of the standard interface. Presumably these should be
renamed to in[0-3]_input. Renaming them is probably not sufficient
though, as I see no scaling done in the driver. As the MAX1111 chip has
a documented full scale of 2.048V, I take it that the LSB of the ADC
has a weight of 8 mV. Exporting raw register values to user-space is
not OK.

So I would appreciate a fixup patch quickly. Otherwise we'll have to
remove the max1111 driver completely, so that it doesn't get used as a
(bad) example by other driver authors [1]. I'm sorry I did not spot the
problem when reviewing the driver originally.

[1] http://lists.lm-sensors.org/pipermail/lm-sensors/2011-October/034070.html

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2011-10-31 13:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 13:16 [lm-sensors] max1111 doesn't implement the standard sysfs interface Jean Delvare
2011-10-31 13:18 ` Jean Delvare [this message]
2011-10-31 14:50 ` [lm-sensors] max1111 doesn't implement the standard sysfs Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111031141814.79b5aa69@endymion.delvare \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.