From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/3] hwmon: (w83627ehf) Clean up probe
Date: Mon, 31 Oct 2011 15:36:17 +0000 [thread overview]
Message-ID: <20111031163617.6cd16539@endymion.delvare> (raw)
In-Reply-To: <20111031152004.28e9f7b8@endymion.delvare>
On Mon, 31 Oct 2011 08:22:59 -0700, Guenter Roeck wrote:
> On Mon, 2011-10-31 at 10:20 -0400, Jean Delvare wrote:
> > The probe function has grown pretty large, I think it's time for some
> > cleanups, starting with these two simple ones:
> > * Move temp3/in6 check for the W83667HG later in the function, where
> > it is done for all other chip types.
> > * Move temperature register setting to a separate function, to avoid
> > code duplication.
> >
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
>
> Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
>
> Do you want to take this series, or should I take it ?
I'll take it, my setup to push things to Linus is operational again.
> > ---
> > Guenter, had you considered adding support for the NCT6775 and NCT6776
> > to a separate driver? The code starts being seriously bloated :(
> >
> No thoughts so far. Might be an option, but I am not sure if/when I
> would have time to work on it. And I would have to get a board with
> NCT6776 on it. If there are any with SandyBridge CPU, I might actually
> get one ;).
Would be great.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-10-31 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 14:20 [lm-sensors] [PATCH 2/3] hwmon: (w83627ehf) Clean up probe function Jean Delvare
2011-10-31 15:22 ` [lm-sensors] [PATCH 2/3] hwmon: (w83627ehf) Clean up probe Guenter Roeck
2011-10-31 15:36 ` Jean Delvare [this message]
2011-10-31 15:53 ` Ian Pilcher
2011-10-31 15:58 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031163617.6cd16539@endymion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.