From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: serialize access to debugs_nodes.list
Date: Mon, 31 Oct 2011 18:00:00 +0100 [thread overview]
Message-ID: <20111031170000.GA3415@joi.lan> (raw)
In-Reply-To: <20111031080656.GD2920@phenom.ffwll.local>
On Mon, Oct 31, 2011 at 09:06:57AM +0100, Daniel Vetter wrote:
> This is just ugly, you're adding a mutex to every drm_info_node, but only
> use the one embedded into the minor. On a quick grep we're only ever using
> the list in there, so I suggest to
> - replace minor->debugfs_node.list with minor->debugfs_list and kill
> ->debugfs_node
> - add the mutex as minor->debugfs_lock
> That way it's clear what's going on.
Yes, you are right. I don't know what the heck I was thinking.
> Also, you've forgotten to add the locking to i915/i915_debugfs.c
Yeah. Will fix it too.
Marcin
next prev parent reply other threads:[~2011-10-31 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-30 22:04 [PATCH] drm: serialize access to debugs_nodes.list Marcin Slusarz
2011-10-31 8:06 ` Daniel Vetter
2011-10-31 17:00 ` Marcin Slusarz [this message]
2011-10-31 17:33 ` [PATCH] drm: serialize access to list of debugfs files Marcin Slusarz
2011-10-31 21:00 ` Daniel Vetter
2011-11-09 21:20 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031170000.GA3415@joi.lan \
--to=marcin.slusarz@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.