From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_bdinfo: simplify local static funcs a bit
Date: Mon, 31 Oct 2011 17:38:32 -0400 [thread overview]
Message-ID: <201110311738.33047.vapier@gentoo.org> (raw)
In-Reply-To: <CAPnjgZ0Scvb2WyxcydL1PFC=x5Xggj44OCFpDPutd-XRgUWO-g@mail.gmail.com>
On Monday 31 October 2011 16:47:08 Simon Glass wrote:
> On Mon, Oct 31, 2011 at 1:44 PM, Mike Frysinger wrote:
> > On Monday 31 October 2011 15:11:35 Simon Glass wrote:
> >> On Sun, Oct 30, 2011 at 5:54 PM, Mike Frysinger wrote:
> >> > If we move the local funcs to the top of the file, and use the
> >> > __maybe_unused define, we can drop a lot of ugly ifdef logic and
> >> > duplicated prototypes.
> >> >
> >> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> >>
> >> This is much cleaner - is the correct style to put attribute tags on
> >> the previous line?
> >
> > when responding to add your own, there isn't any real protocol. just
> > normal e-mail etiquette (no top posting/etc...). patchwork/humans will
> > do the right thing when manually updating the changelog.
>
> Actually I meant the __maybe_unused tag before the function name.
ah. i'm not sure there is a hard rule here. i did that because one line
would make the func def too long to fit.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111031/0b6ba257/attachment.pgp
next prev parent reply other threads:[~2011-10-31 21:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 0:54 [U-Boot] [PATCH] cmd_bdinfo: simplify local static funcs a bit Mike Frysinger
2011-10-31 19:11 ` Simon Glass
2011-10-31 20:44 ` Mike Frysinger
2011-10-31 20:47 ` Simon Glass
2011-10-31 21:38 ` Mike Frysinger [this message]
2011-10-31 21:15 ` Tabi Timur-B04825
2011-10-31 21:49 ` Simon Glass
2011-10-31 22:37 ` Mike Frysinger
2011-10-31 22:51 ` Simon Glass
2011-12-05 3:45 ` [U-Boot] [PATCH v2] " Mike Frysinger
2011-12-06 20:18 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110311738.33047.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.