All of lore.kernel.org
 help / color / mirror / Atom feed
From: Riku Voipio <riku.voipio@iki.fi>
To: Alexander Graf <agraf@suse.de>
Cc: vagrant@debian.org, J.Schauer@email.de,
	qemu-devel Developers <qemu-devel@nongnu.org>,
	Reinhard Max <max@suse.de>
Subject: Re: [Qemu-devel] [PATCH] linux-user: add binfmt wrapper for	argv[0] handling
Date: Mon, 31 Oct 2011 21:16:59 +0200	[thread overview]
Message-ID: <20111031191659.GA11334@afflict.kos.to> (raw)
In-Reply-To: <B6080630-C4FC-4AA6-95FC-59EF6A6F8D57@suse.de>

On Sat, Oct 29, 2011 at 08:08:39PM +0200, Alexander Graf wrote:
> > When using qemu's linux-user binaries through binfmt, argv[0] gets lost
> > along the execution because qemu only gets passed in the full file name
> > to the executable while argv[0] can be something completely different.
> > 
> > This breaks in some subtile situations, such as the grep and make test
> > suites.
> > 
> > This patch adds a wrapper binary called qemu-$TARGET-binfmt that can be
> > used with binfmt's P flag which passes the full path _and_ argv[0] to
> > the binfmt handler.
> > 
> > The binary would be smart enough to be versatile and only exist in the
> > system once, creating the qemu binary path names from its own argv[0].
> > However, this seemed like it didn't fit the make system too well, so
> > we're currently creating a new binary for each target archictecture.
> > 
> > CC: Reinhard Max <max@suse.de>
> > Signed-off-by: Alexander Graf <agraf@suse.de>
 
> Ping?

Last time a wrapper for binfmt was suggested on this list, it was shot down
since people didn't want to add extra binary to the chroot. But your point
is valid, without proper argv[0] things break sometimes. For the same reason
scratchbox has a wrapper binary instead of calling qemu directly...

Riku

  reply	other threads:[~2011-10-31 19:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-30 17:46 [Qemu-devel] [PATCH] linux-user: add binfmt wrapper for argv[0] handling Alexander Graf
2011-10-29 18:08 ` Alexander Graf
2011-10-31 19:16   ` Riku Voipio [this message]
2011-10-31 23:55     ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111031191659.GA11334@afflict.kos.to \
    --to=riku.voipio@iki.fi \
    --cc=J.Schauer@email.de \
    --cc=agraf@suse.de \
    --cc=max@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=vagrant@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.