From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: Lock in the ironlake_panel_vdd_work()
Date: Mon, 31 Oct 2011 21:55:01 +0100
Message-ID: <20111031205501.GA30108@phenom.ffwll.local>
References: <20111031130133.GJ50300@deviant.kiev.zoral.com.ua>
	<20111031133446.GE2920@phenom.ffwll.local>
	<yun7h3l2eq5.fsf@aiko.keithp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id C8DFB9E710
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 31 Oct 2011 13:54:09 -0700 (PDT)
Received: by wyf28 with SMTP id 28so1326978wyf.36
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 31 Oct 2011 13:54:08 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <yun7h3l2eq5.fsf@aiko.keithp.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Oct 31, 2011 at 11:33:22AM -0700, Keith Packard wrote:
> On Mon, 31 Oct 2011 14:34:46 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Mon, Oct 31, 2011 at 03:01:33PM +0200, Konstantin Belousov wrote:
> > > I have a question about ironlake_panel_vdd_work(). Should it use
> > > the device struct_mutex, or need it to be the mode_config.mutex
> > > instead ?
> > 
> > Yeah. This was actually flagged in review by Chris and me, but seems to
> > have been lost in the merge. Keith?
> 
> I thought I fixed that; it must have gotten lost in the fairly steady
> set of rebasing/reworking of that patch sequence.

Yeah, I recall having seen a fixed version somewhere ...

> commit 241dedda2785f040da45576418686490431232d2
> Author: Keith Packard <keithp@keithp.com>
> Date:   Mon Oct 31 11:30:10 2011 -0700
> 
>     drm/i915: Use mode_config.mutex in ironlake_panel_vdd_work
>     
>     Use of the struct_mutex is not correct for locking in mode setting paths.
>     
>     Signed-off-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48