From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm: add some comments to drm_wait_vblank and drm_queue_vblank_event Date: Mon, 31 Oct 2011 22:02:43 +0100 Message-ID: <20111031210243.GC30108@phenom.ffwll.local> References: <1320081117-15020-1-git-send-email-ihadzic@research.bell-labs.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 21B399E710 for ; Mon, 31 Oct 2011 14:01:46 -0700 (PDT) Received: by wyf28 with SMTP id 28so1335360wyf.36 for ; Mon, 31 Oct 2011 14:01:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1320081117-15020-1-git-send-email-ihadzic@research.bell-labs.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Ilija Hadzic Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, Oct 31, 2011 at 01:11:57PM -0400, Ilija Hadzic wrote: > during the review of the fix for locks problems in drm_wait_vblank, > a couple of false concerns were raised about how the drm_vblank_get > and drm_vblank_put are used in this function; it turned out that the > code is correct and that it cannot be simplified > > add a few comments to explain non-obvious flows in the code, > to prevent "false alarms" in the future > > v2: incorporate comments received from Daniel Vetter > > Signed-off-by: Ilija Hadzic Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48