From: Jim Rees <rees@umich.edu>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Benny Halevy <bhalevy@tonian.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] Silence compiler warning
Date: Mon, 31 Oct 2011 23:01:40 -0400 [thread overview]
Message-ID: <20111101030140.GA4449@umich.edu> (raw)
In-Reply-To: <1320116217.10028.44.camel@lade.trondhjem.org>
Trond Myklebust wrote:
On Mon, 2011-10-31 at 22:42 -0400, Jim Rees wrote:
> Trond Myklebust wrote:
>
> On Mon, 2011-10-31 at 21:37 -0400, Jim Rees wrote:
> > I think this is still needed, isn't it? I haven't tried compiling
> > nfs-for-next but I don't see a fix for it in there.
>
> AFAICS, this is a bogus warning: if lo is uninitialised, we will
> automatically exit with a return value of NFS4ERR_NOMATCHING_LAYOUT.
>
> Yes, the warning is bogus. I just want the damn compiler to shut up so I
> can see if there are any real warnings.
How about cleaning up the whole unnecessary "bool found" crap that has
it confused? You can easily replace that with a test for 'ino != NULL'.
We don't usually "fix" compiler bugs by changing valid kernel code, but
cleanups are acceptable if they help to clarify what is going on.
Oh, another thing: that code will currently race very nicely against
'umount', and looks capable of triggering the 'VFS: Busy inodes after
unmount of foo. Self-destruct in 5 seconds. Have a nice day..." since
it doesn't do anything to pin the super block while holding a reference
to the inode.
There's a patch in Benny's tree that I think addresses these issues in
addition to the compiler warnings. Maybe Benny would like to move it
forward?
next prev parent reply other threads:[~2011-11-01 3:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 1:37 [PATCH] Silence compiler warning Jim Rees
2011-11-01 2:30 ` Trond Myklebust
2011-11-01 2:42 ` Jim Rees
2011-11-01 2:56 ` Trond Myklebust
2011-11-01 3:01 ` Jim Rees [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-18 13:07 Benny Halevy
2011-10-17 0:06 Jim Rees
2011-10-17 1:57 ` Benny Halevy
2011-10-17 2:36 ` Jim Rees
2011-10-18 9:50 ` Stanislav Kinsbursky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101030140.GA4449@umich.edu \
--to=rees@umich.edu \
--cc=Trond.Myklebust@netapp.com \
--cc=bhalevy@tonian.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.