From: Pablo Neira Ayuso <pablo@netfilter.org>
To: akpm@linux-foundation.org
Cc: kaber@trash.net, davem@davemloft.net, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, alex@alex.org.uk,
stable@kernel.org, stable@vger.kernel.org
Subject: Re: [patch 1/1] net/netfilter/nf_conntrack_netlink.c: fix Oops on container destroy
Date: Tue, 1 Nov 2011 09:07:15 +0100 [thread overview]
Message-ID: <20111101080715.GA4268@1984> (raw)
In-Reply-To: <201110312133.p9VLXDUu003535@hpaq6.eem.corp.google.com>
On Mon, Oct 31, 2011 at 02:33:12PM -0700, akpm@linux-foundation.org wrote:
> diff -puN net/netfilter/nf_conntrack_netlink.c~net-netfilter-nf_conntrack_netlinkc-fix-oops-on-container-destroy net/netfilter/nf_conntrack_netlink.c
> --- a/net/netfilter/nf_conntrack_netlink.c~net-netfilter-nf_conntrack_netlinkc-fix-oops-on-container-destroy
> +++ a/net/netfilter/nf_conntrack_netlink.c
> @@ -570,6 +570,11 @@ ctnetlink_conntrack_event(unsigned int e
> return 0;
>
> net = nf_ct_net(ct);
> +
> + /* container deinit, netlink may have died before death_by_timeout */
> + if (!net->nfnl)
> + return 0;
> +
This patch is a workaround and it is incomplete (it doesn't include
the expectation part). The correct fix requires to finish container
support for nfnetlink, which seems incomplete.
I was expecting some feedback from Alexey Dobriyan with no success.
If we apply this, we'll have to apply similar workaround in other
parts of the code.
prev parent reply other threads:[~2011-11-01 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 21:33 [patch 1/1] net/netfilter/nf_conntrack_netlink.c: fix Oops on container destroy akpm
2011-11-01 8:07 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101080715.GA4268@1984 \
--to=pablo@netfilter.org \
--cc=akpm@linux-foundation.org \
--cc=alex@alex.org.uk \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.