From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/1] netfilter: do not propagate nf_queue errors in nf_hook_slow
Date: Tue, 1 Nov 2011 10:11:19 +0100 [thread overview]
Message-ID: <20111101091119.GA5545@1984> (raw)
In-Reply-To: <1320060016-9390-1-git-send-email-fw@strlen.de>
On Mon, Oct 31, 2011 at 12:20:16PM +0100, Florian Westphal wrote:
> commit f15850861860636c905b33a9a5be3dcbc2b0d56a
> (netfilter: nfnetlink_queue: return error number to caller)
> erronously assigns the return value of nf_queue() to the "ret" value.
>
> This can cause bogus return values if we encounter QUEUE verdict
> when bypassing is enabled, the listener does not exist and the
> next hook returns NF_STOLEN.
>
> In this case nf_hook_slow returned -ESRCH instead of 0.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied, thanks.
prev parent reply other threads:[~2011-11-01 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 11:20 [PATCH 1/1] netfilter: do not propagate nf_queue errors in nf_hook_slow Florian Westphal
2011-11-01 9:11 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101091119.GA5545@1984 \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.