All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Ilya Zykov <ilya@ilyx.ru>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TTY: tty flip buffer change reserve memory strategy.
Date: Tue, 1 Nov 2011 11:41:38 +0000	[thread overview]
Message-ID: <20111101114138.1debca90@bob.linux.org.uk> (raw)
In-Reply-To: <4EA69BE2.3020703@ilyx.ru>

> Pty use chunk more 256 bytes very often. More program for communicate
> with pppd use pty master - slave. If often kmalloc()-kfree() calls
> don't provoke memory fragmentation and flush TLB, I agree it isn't
> important.

I think any work of this nature ought to involve benchmarking. That
would answer the questions better. kmalloc/kfree is a smart allocator
so shouldn't cause problems, and it doesn't manipulate address space so
shouldn't cause TLB misses.

You want to make these changes, you say they are needed, but what
actually talks is real numbers.

Alan

  reply	other threads:[~2011-11-01 11:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-23 21:17 [PATCH] TTY: tty flip buffer change reserve memory strategy Ilya Zykov
2011-10-25  7:45 ` Alan Cox
2011-10-25 11:22   ` Ilya Zykov
2011-11-01 11:41     ` Alan Cox [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-10-23 19:04 Ilya Zykov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111101114138.1debca90@bob.linux.org.uk \
    --to=alan@linux.intel.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=ilya@ilyx.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.