All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, qi.wang@intel.com,
	yong.y.wang@intel.com, joel.clark@intel.com,
	kok.howg.ewe@intel.com
Subject: Re: [PATCH 2/2] pch_uart: Delete modem status interrupt enable code
Date: Tue, 1 Nov 2011 12:57:57 +0000	[thread overview]
Message-ID: <20111101125757.4ef7f883@bob.linux.org.uk> (raw)
In-Reply-To: <1319697919-5623-2-git-send-email-tomoya-linux@dsn.lapis-semi.com>

> (pch_uart device has auto hardware flow control function. So,
> pch_uart driver doesn't have to control modem status interrupt.)

This is true for flow control bits but not for incoming carrier detect ?

> This patch deletes the code.

> +	dev_info(priv->port.dev,
> +		"PCH UART : Modem status interrupt is not
> supported.\n"); }

dev_info seems wrong here. Does the user need to know this ?

  reply	other threads:[~2011-11-01 12:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-27  6:45 [PATCH 1/2] pch_uart: Fix hw-flow control issue Tomoya MORINAGA
2011-10-27  6:45 ` [PATCH 2/2] pch_uart: Delete modem status interrupt enable code Tomoya MORINAGA
2011-11-01 12:57   ` Alan Cox [this message]
2011-11-02  5:52     ` Tomoya MORINAGA
2011-11-02 11:00       ` Alan Cox
2011-11-10  2:11         ` Tomoya MORINAGA
2011-11-01 12:55 ` [PATCH 1/2] pch_uart: Fix hw-flow control issue Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111101125757.4ef7f883@bob.linux.org.uk \
    --to=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=joel.clark@intel.com \
    --cc=kok.howg.ewe@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=qi.wang@intel.com \
    --cc=tomoya-linux@dsn.lapis-semi.com \
    --cc=yong.y.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.