From: "J. Bruce Fields" <bfields@fieldses.org>
To: Bryan Schumaker <bjschuma@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/3] NFSD: Added fault injection
Date: Tue, 1 Nov 2011 10:35:38 -0400 [thread overview]
Message-ID: <20111101143538.GE32248@fieldses.org> (raw)
In-Reply-To: <4EB000A6.9040508@netapp.com>
On Tue, Nov 01, 2011 at 10:22:30AM -0400, Bryan Schumaker wrote:
> On Tue 01 Nov 2011 10:17:46 AM EDT, J. Bruce Fields wrote:
> >> I didn't realize that slabs were initialized in the state_init()
> >> function, I'll fix that.
> >
> > I'll admit that's confusing. Any suggestion to make it clearer welcome.
>
> Sure. The comment after the call to nfs4_state_init() is "nfs4 locking
> state". Maybe this could be changed to "nfs4 locking state and slabs"?
> I can make this change and send it as a separate patch if you would
> like.
If there was a way to fix the code itself to make it clearer, that's
usually better--a comment is a workaround.
--b.
next prev parent reply other threads:[~2011-11-01 14:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 11:20 [PATCH 1/3] NFSD: Added fault injection bjschuma
2011-10-24 11:20 ` [PATCH 2/3] NFSD: Added fault injection script bjschuma
2011-10-24 11:20 ` [PATCH 3/3] NFSD: Added fault injection documentation bjschuma
2011-10-28 21:24 ` [PATCH 1/3] NFSD: Added fault injection J. Bruce Fields
2011-11-01 14:08 ` Bryan Schumaker
2011-11-01 14:17 ` J. Bruce Fields
2011-11-01 14:22 ` Bryan Schumaker
2011-11-01 14:35 ` J. Bruce Fields [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-11-01 17:35 bjschuma
2011-11-04 21:30 ` J. Bruce Fields
2011-10-07 17:44 bjschuma
2011-10-17 22:18 ` J. Bruce Fields
2011-10-17 22:57 ` Bryan Schumaker
2011-10-18 17:43 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101143538.GE32248@fieldses.org \
--to=bfields@fieldses.org \
--cc=bjschuma@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.