From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC don't clobber platform DMA driver ops Date: Tue, 1 Nov 2011 18:49:56 +0000 Message-ID: <20111101184955.GJ10029@opensource.wolfsonmicro.com> References: <1320173157-8595-1-git-send-email-alan.tull@freescale.com> <9E5C29D1DC97674D8FB0F7D26508F7861F05DB@039-SN1MPN1-005.039d.mgd.msft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id A9D1110388D for ; Tue, 1 Nov 2011 19:49:57 +0100 (CET) Content-Disposition: inline In-Reply-To: <9E5C29D1DC97674D8FB0F7D26508F7861F05DB@039-SN1MPN1-005.039d.mgd.msft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Tull Alan-R80115 Cc: "alsa-devel@alsa-project.org" , "lrg@slimlogic.co.uk" List-Id: alsa-devel@alsa-project.org On Tue, Nov 01, 2011 at 06:46:52PM +0000, Tull Alan-R80115 wrote: > This patch creates and populates a ops struct for each call to soc_pcm_new. This isn't very idiomatic - a much more idiomatic solution would be to add new indirection functions which do the lookups. While it's probably not going to make much difference for most things there's operations like ioctl() which definitely don't look at all DMA specific in there.