From: Greg KH <gregkh@suse.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jiri Slaby <jirislaby@gmail.com>,
David Miller <davem@davemloft.net>,
Mikulas Patocka <mpatocka@redhat.com>,
akpm@linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH] sysfs: Make sysfs_rename safe with sysfs_dirents in rbtrees.
Date: Tue, 1 Nov 2011 14:19:15 -0700 [thread overview]
Message-ID: <20111101211915.GA20290@suse.de> (raw)
In-Reply-To: <m1mxcgrl7q.fsf_-_@fess.ebiederm.org>
On Tue, Nov 01, 2011 at 07:06:17AM -0700, Eric W. Biederman wrote:
>
> In sysfs_rename remove the optimization of not calling sysfs_unlink_sibling
> and sysfs_link_sibling if the renamed parent directory is not changing.
> This optimization is no longer valid now that sysfs dirents are stored in an
> rbtree sorted by name.
>
> Move the assignment of s_ns before the call of sysfs_link_sibling. With no
> sysfs_dirent fields changing after the call of sysfs_link_sibling this allows
> sysfs_link_sibling to take any of the directory entries into account when
> it builds the rbtrees, and s_ns looks like a prime canidate to be used
> in the rbtree in the future.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Looks good, Linus, thanks for taking this in your tree already.
greg k-h
next prev parent reply other threads:[~2011-11-01 21:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 10:32 [GIT] Networking David Miller
2011-10-25 10:32 ` David Miller
2011-10-25 11:46 ` Linus Torvalds
2011-10-25 11:56 ` Greg KH
2011-10-25 12:03 ` Linus Torvalds
[not found] ` <m1wrbtb4rj.fsf@fess.ebiederm.org>
2011-10-25 13:12 ` Linus Torvalds
2011-10-25 13:13 ` Greg KH
2011-10-29 23:03 ` Broken link in /sys/class/net/ [was: [GIT] Networking] Jiri Slaby
2011-10-30 4:49 ` Eric W. Biederman
2011-10-30 20:49 ` Jiri Slaby
[not found] ` <m1mxcgrl7q.fsf_-_@fess.ebiederm.org>
2011-11-01 21:19 ` Greg KH [this message]
2011-10-25 12:26 ` [GIT] Networking Linus Torvalds
2011-10-25 12:26 ` Linus Torvalds
2011-11-04 17:03 ` Johannes Berg
2011-11-04 17:07 ` Ben Greear
2011-11-07 11:40 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101211915.GA20290@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.