From: Ted Ts'o <tytso@mit.edu>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org, Eric Gouriou <egouriou@google.com>
Subject: Re: [PATCH] ext4: let ext4_ext_convet_to_initialized initialize var(eh) before using it
Date: Tue, 1 Nov 2011 18:52:22 -0400 [thread overview]
Message-ID: <20111101225222.GH32161@thunk.org> (raw)
In-Reply-To: <1320110481-12080-1-git-send-email-xiaoqiangnk@gmail.com>
On Tue, Nov 01, 2011 at 09:21:21AM +0800, Yongqiang Yang wrote:
> ext4_ext_convert_to_initialized() does not initialize eh before using it
> and this is introduced in commit 864d21652.
>
> Cc:Eric Gouriou <egouriou@google.com>
> Cc:"Theodore Ts'o" <tytso@mit.edu>
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
> eof_block = map->m_lblk + map->m_len;
>
> depth = ext_depth(inode);
> + eh = path[depth].p_hdr;
> ex = path[depth].p_ext;
> ee_block = le32_to_cpu(ex->ee_block);
> ee_len = ext4_ext_get_actual_len(ex);
Hmmm, nice catch.
Looks like Eric dropped this line when he forward ported this patch to
v3.1. Interestingly, I did test this using xfstests, and it didn't
complain. Which probably means we don't have a good test coverage
that triggers the specific preconditions of this optimization. Oops.
I'll fix this up now.
Eric, when you have a chance, could you work up an xfstests test that
automates the various tests that you ran manually when you developed
this patch? Thanks!!
- Ted
next prev parent reply other threads:[~2011-11-01 22:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 1:21 [PATCH] ext4: let ext4_ext_convet_to_initialized initialize var(eh) before using it Yongqiang Yang
2011-11-01 3:31 ` Yongqiang Yang
2011-11-01 22:52 ` Ted Ts'o [this message]
[not found] ` <CAMUAhYSh4VUbh3oG9hwi0FxMs=gMDiOHqvRhDgZTmP-_8PuW3g@mail.gmail.com>
2011-11-02 8:22 ` Eric Gouriou
2011-11-02 15:04 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101225222.GH32161@thunk.org \
--to=tytso@mit.edu \
--cc=egouriou@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.