From: Dave Jones <davej@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, Matthew Daley <mattjd@gmail.com>
Subject: Re: Fix NULL dereference in x25_recvmsg
Date: Tue, 1 Nov 2011 22:15:25 -0400 [thread overview]
Message-ID: <20111102021525.GA8512@redhat.com> (raw)
In-Reply-To: <1320199845.4728.23.camel@edumazet-laptop>
On Wed, Nov 02, 2011 at 03:10:45AM +0100, Eric Dumazet wrote:
> Le mardi 01 novembre 2011 à 21:53 -0400, Dave Jones a écrit :
> > commit cb101ed2 in 3.0 introduced a bug in x25_recvmsg()
> > When passed bogus junk from userspace, x25->neighbour can be NULL,
> > as shown in this oops..
> >
>
> Your patch seems fine but :
>
> Are you sure this bug is not present on previous kernels ?
>
> It seems we had prior to this commit :
>
> skb_pull(skb, x25->neighbour->extended ?
> X25_EXT_MIN_LEN : X25_STD_MIN_LEN);
It might have been possible with a specifically crafted set of arguments.
It never showed up in testing before now, probably because we were
returning from the function before we got to that skb_pull
via all the other tests that get performed.
Dave
next prev parent reply other threads:[~2011-11-02 2:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 1:53 Fix NULL dereference in x25_recvmsg Dave Jones
2011-11-02 2:10 ` Eric Dumazet
2011-11-02 2:15 ` Dave Jones [this message]
2011-11-02 2:19 ` Eric Dumazet
2011-11-02 2:21 ` Eric Dumazet
2011-11-02 2:16 ` Eric Dumazet
2011-11-02 2:26 ` [v2] " Dave Jones
2011-11-02 2:30 ` Eric Dumazet
2011-11-02 4:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111102021525.GA8512@redhat.com \
--to=davej@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=mattjd@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.