From: Vivek Goyal <vgoyal@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
torvalds@linux-foundation.org, sfr@canb.auug.org.au,
linux-fsdevel@vger.kernel.org, Tao Ma <boyu.mt@taobao.com>,
Andy Whitcroft <apw@canonical.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
axboe@kernel.dk, Tejun Heo <tj@kernel.org>
Subject: Re: caching the request queue was Re: interims VFS queue
Date: Tue, 1 Nov 2011 22:47:48 -0400 [thread overview]
Message-ID: <20111102024748.GA12219@redhat.com> (raw)
In-Reply-To: <20111029114916.GF14103@one.firstfloor.org>
On Sat, Oct 29, 2011 at 01:49:16PM +0200, Andi Kleen wrote:
> On Sat, Oct 29, 2011 at 06:58:56AM -0400, Christoph Hellwig wrote:
> > On Fri, Oct 28, 2011 at 03:09:36PM -0700, Andrew Morton wrote:
> > > 1: What happened with Andi's "dio: optimize cache misses in the
> > > submission path"? (Against which I have checkpatch fixes and
> > > #include linux/prefetch.h, btw)
> >
> > It has mostly been merged, including all whitespace fixes and some
> > folding. What is missing is the last two patchees because I don't
> > want to put the request_queue caching in until the remaining
> > lifetime issues for the request queue are sorted out, and the last
> > patch (which would need prefetch.h) depends on it.
>
> I asked Jens in person and he seemed ok with with the queue
> caching. Jens can you ack?
If you are caching queue in block device, you probably need to take
queue reference too using blk_get_queue().
Thanks
Vivek
next prev parent reply other threads:[~2011-11-02 2:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 13:30 interims VFS queue Christoph Hellwig
2011-10-28 18:43 ` Stephen Rothwell
2011-10-28 19:08 ` Linus Torvalds
2011-10-28 19:31 ` Stephen Rothwell
2011-10-28 19:13 ` Stephen Rothwell
2011-10-28 22:09 ` Andrew Morton
2011-10-29 10:58 ` Christoph Hellwig
2011-10-29 11:49 ` caching the request queue was " Andi Kleen
2011-11-02 2:47 ` Vivek Goyal [this message]
2011-10-30 7:36 ` Tao Ma
2011-10-31 7:24 ` [PATCH for 3.2] fs/direct-io.c: Calculate fs_count correctly in get_more_blocks Tao Ma
2011-10-31 18:12 ` Jeff Moyer
2011-11-01 3:31 ` Tao Ma
2011-11-02 2:26 ` [PATCH V2 " Tao Ma
2011-11-02 7:36 ` Christoph Hellwig
2011-11-03 3:21 ` Tao Ma
2011-10-29 13:48 ` interims VFS queue Aneesh Kumar K.V
2011-10-29 14:37 ` Christoph Hellwig
2011-10-30 15:47 ` Hans Verkuil
2011-11-02 13:28 ` interims VFS queue, part2 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111102024748.GA12219@redhat.com \
--to=vgoyal@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=apw@canonical.com \
--cc=axboe@kernel.dk \
--cc=boyu.mt@taobao.com \
--cc=hch@infradead.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.