From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH v2] drivers: i915: Default max backlight brightness value Date: Wed, 2 Nov 2011 02:54:06 +0000 Message-ID: <20111102025406.GA12566@srcf.ucam.org> References: <1320200595-16851-1-git-send-email-sque@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cavan.codon.org.uk (cavan.codon.org.uk [93.93.128.6]) by gabe.freedesktop.org (Postfix) with ESMTP id EA2C29E779 for ; Tue, 1 Nov 2011 20:11:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1320200595-16851-1-git-send-email-sque@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Simon Que Cc: intel-gfx@lists.freedesktop.org, olofj@chromium.org List-Id: intel-gfx@lists.freedesktop.org Again, adding arbitrary constants without any explanation for why you're making this the default really isn't acceptable. We have no way to determine whether fixing one machine is worth making things worse for another. -- Matthew Garrett | mjg59@srcf.ucam.org