From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, Paul Bolle <pebolle@tiscali.nl>,
Ciaran McCormick <ciaranmccormick@gmail.com>,
gregkh@suse.de, linux-kernel@vger.kernel.org,
shemminger@vyatta.com
Subject: Re: [PATCH] Stageing: bcm: fixed spacing coding style in led_control.c
Date: Wed, 2 Nov 2011 09:26:51 +0300 [thread overview]
Message-ID: <20111102062651.GE4682@mwanda> (raw)
In-Reply-To: <1320202495.15779.11.camel@Joe-Laptop>
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
On Wed, Nov 02, 2011 at 04:54:55AM +0200, Joe Perches wrote:
> On Tue, 2011-11-01 at 23:22 +0300, Dan Carpenter wrote:
> > You're right that this driver needs a lot of work.
> []
> > I'd prefer a series of patches:
>
> Thanks Dan, that's a good summary of useful changes
> and their best order. Couple of comments:
>
> > [patch 1/3] Staging: bcm: fix whitespace in led_control.c
> > This would address tabs vs spaces, extra prohibited spaces, and
> > spaces required around certain chars. Also it would add blank lines
> > between functions and between declarations and code.
>
> And verify with git diff -w and object diffs.
>
How are you doing the object diff? I've tried just using diff
against the object files but the line number changes mess everything
up.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-11-02 6:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 10:44 [PATCH] Stageing: bcm: fixed spacing coding style in led_control.c Ciaran McCormick
2011-11-01 11:07 ` Paul Bolle
2011-11-01 20:22 ` Dan Carpenter
2011-11-02 2:54 ` Joe Perches
2011-11-02 6:26 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111102062651.GE4682@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ciaranmccormick@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.