From: Dan Carpenter <dan.carpenter@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Giridhar Malavali <giridhar.malavali@qlogic.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: re: [SCSI] compat_ioct: fix bsg SG_IO
Date: Wed, 2 Nov 2011 11:16:42 +0300 [thread overview]
Message-ID: <20111102081642.GD4751@mwanda> (raw)
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
84eb8fb42c120 "[SCSI] compat_ioct: fix bsg SG_IO" introduces an
uninitialized variable use.
278 static int sg_ioctl_trans(unsigned int fd, unsigned int cmd,
279 sg_io_hdr32_t __user *sgio32)
280 {
281 sg_io_hdr_t __user *sgio;
282 u16 iovec_count;
283 u32 data;
284 void __user *dxferp;
285 int err;
286 int interface_id;
287
288 if (get_user(interface_id, &sgio32->interface_id))
^^^^^^
sgio32 is unitialized here. Unfortunately Gcc doesn't warn about it.
289 return -EFAULT;
290 if (interface_id != 'S')
291 return sys_ioctl(fd, cmd, (unsigned long)sgio32);
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2011-11-02 8:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 8:16 Dan Carpenter [this message]
2011-11-02 8:58 ` [SCSI] compat_ioct: fix bsg SG_IO James Bottomley
2011-11-02 9:24 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111102081642.GD4751@mwanda \
--to=dan.carpenter@oracle.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=giridhar.malavali@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.