All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org, rjw@sisk.pl
Subject: Re: REGRESSION: "perf: Add PM notifiers ..." breaks resume
Date: Thu, 3 Nov 2011 08:37:25 +0100	[thread overview]
Message-ID: <20111103073725.GA7319@elte.hu> (raw)
In-Reply-To: <CA+55aFwCf41GFOVA656-ZgZB5mBNkpH3KqRfJ_Ornkn3RWF5gQ@mail.gmail.com>

* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> Peter, Ingo, ping?
> 
> Quite frankly, I'm inclined to revert that patch just for being 
> horribly ugly and apparently broken regardless of the fact that it 
> also causes a regression.
> 
> *Notifiers* for doing something like this? smp_call_function? 
> That's just utter sh*t, guys.
> 
> If it is CPU state, then it should damn well be suspended and 
> resumed as part of CPU suspend and resume. No IPI cross-calls to 
> ask other CPU's to do random work, no crap like that.

Agreed, that's quite crappy.

> Comments? Should I just revert the thing (silence is obviously 
> "yes" in cases like this where we are talking about regressions 
> anyway)?

Yep, please revert it until we do the right fix. (I can queue up the 
revert too)

Thanks,

	Ingo

  reply	other threads:[~2011-11-03  7:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02 13:49 REGRESSION: "perf: Add PM notifiers ..." breaks resume Andi Kleen
2011-11-03  0:00 ` Linus Torvalds
2011-11-03  7:37   ` Ingo Molnar [this message]
2011-11-03 14:44     ` Linus Torvalds
2011-11-03 19:46       ` Ingo Molnar
2011-11-06 19:57   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111103073725.GA7319@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.