From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [PATCH 1/1] atmel/spi: fix missing probe during the switch to module_platform_driver Date: Thu, 3 Nov 2011 16:14:26 +0100 Message-ID: <20111103151426.GJ7136@game.jcrosoft.org> References: <1320331706-4946-1-git-send-email-plagnioj@jcrosoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Grant Likely , spi-devel-general@lists.sourceforge.net, Greg Kroah-Hartman , Nicolas Ferre , linux-arm-kernel@lists.infradead.org To: Deepak Saxena Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On 10:55 Thu 03 Nov , Deepak Saxena wrote: > On Thu, Nov 3, 2011 at 10:48 AM, Jean-Christophe PLAGNIOL-VILLARD > wrote: > > in commit 940ab889 > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > Cc: Greg Kroah-Hartman > > Cc: Grant Likely > > Cc: Nicolas Ferre > > --- > > =A0arch/arm/mach-at91/include/mach/at91_aic.h | =A0 =A02 +- > > =A0drivers/spi/spi-atmel.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0= =A01 + > > =A02 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/arch/arm/mach-at91/include/mach/at91_aic.h b/arch/arm/mach= -at91/include/mach/at91_aic.h > > index 4b0a57e..f163bb6 100644 > > --- a/arch/arm/mach-at91/include/mach/at91_aic.h > > +++ b/arch/arm/mach-at91/include/mach/at91_aic.h > > @@ -20,7 +20,7 @@ > > =A0extern void __iomem *at91_aic_base; > > > > =A0#define at91_aic_read(field) \ > > - =A0 =A0 =A0 __raw_read(at91_aic_base + field) > > + =A0 =A0 =A0 __raw_readl(at91_aic_base + field) > > > > =A0#define at91_aic_write(field, value) \ > > =A0 =A0 =A0 =A0__raw_writel(value, at91_aic_base + field); > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > > index 79665e2..a691240 100644 > > --- a/drivers/spi/spi-atmel.c > > +++ b/drivers/spi/spi-atmel.c > > @@ -1072,6 +1072,7 @@ static struct platform_driver atmel_spi_driver = =3D { > > =A0 =A0 =A0 =A0}, > > =A0 =A0 =A0 =A0.suspend =A0 =A0 =A0 =A0=3D atmel_spi_suspend, > > =A0 =A0 =A0 =A0.resume =A0 =A0 =A0 =A0 =3D atmel_spi_resume, > > + =A0 =A0 =A0 .probe =A0 =A0 =A0 =A0 =A0=3D atmel_spi_probe, > > =A0 =A0 =A0 =A0.remove =A0 =A0 =A0 =A0 =3D __exit_p(atmel_spi_remove), > > =A0}; > > =A0module_platform_driver(atmel_spi_driver); > = > Jean, > = > This looks it should be two separate patches, one for the missing probe, > one for the raw_read -> raw_readl. Yes I found when I receive the e-mail and already send the v2 Best Regards, J. From mboxrd@z Thu Jan 1 00:00:00 1970 From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD) Date: Thu, 3 Nov 2011 16:14:26 +0100 Subject: [PATCH 1/1] atmel/spi: fix missing probe during the switch to module_platform_driver In-Reply-To: References: <1320331706-4946-1-git-send-email-plagnioj@jcrosoft.com> Message-ID: <20111103151426.GJ7136@game.jcrosoft.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10:55 Thu 03 Nov , Deepak Saxena wrote: > On Thu, Nov 3, 2011 at 10:48 AM, Jean-Christophe PLAGNIOL-VILLARD > wrote: > > in commit 940ab889 > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > Cc: Greg Kroah-Hartman > > Cc: Grant Likely > > Cc: Nicolas Ferre > > --- > > ?arch/arm/mach-at91/include/mach/at91_aic.h | ? ?2 +- > > ?drivers/spi/spi-atmel.c ? ? ? ? ? ? ? ? ? ?| ? ?1 + > > ?2 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/arch/arm/mach-at91/include/mach/at91_aic.h b/arch/arm/mach-at91/include/mach/at91_aic.h > > index 4b0a57e..f163bb6 100644 > > --- a/arch/arm/mach-at91/include/mach/at91_aic.h > > +++ b/arch/arm/mach-at91/include/mach/at91_aic.h > > @@ -20,7 +20,7 @@ > > ?extern void __iomem *at91_aic_base; > > > > ?#define at91_aic_read(field) \ > > - ? ? ? __raw_read(at91_aic_base + field) > > + ? ? ? __raw_readl(at91_aic_base + field) > > > > ?#define at91_aic_write(field, value) \ > > ? ? ? ?__raw_writel(value, at91_aic_base + field); > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > > index 79665e2..a691240 100644 > > --- a/drivers/spi/spi-atmel.c > > +++ b/drivers/spi/spi-atmel.c > > @@ -1072,6 +1072,7 @@ static struct platform_driver atmel_spi_driver = { > > ? ? ? ?}, > > ? ? ? ?.suspend ? ? ? ?= atmel_spi_suspend, > > ? ? ? ?.resume ? ? ? ? = atmel_spi_resume, > > + ? ? ? .probe ? ? ? ? ?= atmel_spi_probe, > > ? ? ? ?.remove ? ? ? ? = __exit_p(atmel_spi_remove), > > ?}; > > ?module_platform_driver(atmel_spi_driver); > > Jean, > > This looks it should be two separate patches, one for the missing probe, > one for the raw_read -> raw_readl. Yes I found when I receive the e-mail and already send the v2 Best Regards, J.