From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 4/8] drm/ttm: use ttm put pages function to properly
	restore cache attribute
Date: Thu, 3 Nov 2011 14:35:01 -0400
Message-ID: <20111103183501.GA521@phenom.dumpdata.com>
References: <1320277075-19980-1-git-send-email-j.glisse@gmail.com>
	<1320277075-19980-5-git-send-email-j.glisse@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117])
	by gabe.freedesktop.org (Postfix) with ESMTP id 83EC29EF79
	for <dri-devel@lists.freedesktop.org>;
	Thu,  3 Nov 2011 11:35:12 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1320277075-19980-5-git-send-email-j.glisse@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: j.glisse@gmail.com
Cc: thellstrom@vmware.com, Jerome Glisse <jglisse@redhat.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Wed, Nov 02, 2011 at 07:37:51PM -0400, j.glisse@gmail.com wrote:
> From: Jerome Glisse <jglisse@redhat.com>
> 
> On failure we need to make sure the page we free has wb cache
> attribute. Do this pas call the proper ttm page helper function.
> 
> Signed-off-by: Jerome Glisse <jglisse@redhat.com>

Reviewed-by...
> ---
>  drivers/gpu/drm/ttm/ttm_tt.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
> index 8b7a6d0..3fb4c6d 100644
> --- a/drivers/gpu/drm/ttm/ttm_tt.c
> +++ b/drivers/gpu/drm/ttm/ttm_tt.c
> @@ -89,7 +89,10 @@ static struct page *__ttm_tt_get_page(struct ttm_tt *ttm, int index)
>  	}
>  	return p;
>  out_err:
> -	put_page(p);
> +	INIT_LIST_HEAD(&h);
> +	list_add(&p->lru, &h);
> +	ttm_put_pages(&h, 1, ttm->page_flags,
> +		      ttm->caching_state, &ttm->dma_address[index]);
>  	return NULL;
>  }
>  
> -- 
> 1.7.1