From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 6/8] drm/ttm: test for dma_address array allocation failure
Date: Thu, 3 Nov 2011 14:45:24 -0400
Message-ID: <20111103184524.GC521@phenom.dumpdata.com>
References: <1320277075-19980-1-git-send-email-j.glisse@gmail.com>
	<1320277075-19980-7-git-send-email-j.glisse@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227])
	by gabe.freedesktop.org (Postfix) with ESMTP id 2CF65A0DE3
	for <dri-devel@lists.freedesktop.org>;
	Thu,  3 Nov 2011 11:45:37 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1320277075-19980-7-git-send-email-j.glisse@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: j.glisse@gmail.com
Cc: thellstrom@vmware.com, Jerome Glisse <jglisse@redhat.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Wed, Nov 02, 2011 at 07:37:53PM -0400, j.glisse@gmail.com wrote:
> From: Jerome Glisse <jglisse@redhat.com>
> 
> Signed-off-by: Jerome Glisse <jglisse@redhat.com>

Reviewed-by-me.
> ---
>  drivers/gpu/drm/ttm/ttm_tt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
> index 2dd45ca..58ea7dc 100644
> --- a/drivers/gpu/drm/ttm/ttm_tt.c
> +++ b/drivers/gpu/drm/ttm/ttm_tt.c
> @@ -298,7 +298,7 @@ struct ttm_tt *ttm_tt_create(struct ttm_bo_device *bdev, unsigned long size,
>  	ttm->dummy_read_page = dummy_read_page;
>  
>  	ttm_tt_alloc_page_directory(ttm);
> -	if (!ttm->pages) {
> +	if (!ttm->pages || !ttm->dma_address) {
>  		ttm_tt_destroy(ttm);
>  		printk(KERN_ERR TTM_PFX "Failed allocating page table\n");
>  		return NULL;
> -- 
> 1.7.1