All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Hillf Danton <dhillf@gmail.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Keep TLB cache hot while flushing
Date: Fri, 4 Nov 2011 14:56:27 +0000	[thread overview]
Message-ID: <20111104145627.GA13043@linux-mips.org> (raw)
In-Reply-To: <4EAAD55D.4070106@gmail.com>

On Fri, Oct 28, 2011 at 09:16:29AM -0700, David Daney wrote:

> >If we only flush the TLB of the given huge page, the TLB cache remains hot for
> >the relevant mm as it is, and less will be refilled after flush, huge or not.
> >
> >As always all comments and ideas welcome.
> >
> 
> I haven't tested it, but it looks correct.  When I wrote the
> original flush_tlb_mm(), I was in a hurry and was more concerned
> about maintaining TLB consistency, rather than performance.

Yes, looks sane and like an obvious performance improvment.  but as always
with TLB stuff I'm paranoid so I've applied this to my 3.3 queue for it to
be tested well.

Hillf, do you have any benchmark numbers for this?

Thanks folks!

  Ralf

  reply	other threads:[~2011-11-04 14:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28 14:15 [PATCH] MIPS: Keep TLB cache hot while flushing Hillf Danton
2011-10-28 16:16 ` David Daney
2011-11-04 14:56   ` Ralf Baechle [this message]
2011-11-06  5:08     ` Hillf Danton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111104145627.GA13043@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=ddaney.cavm@gmail.com \
    --cc=dhillf@gmail.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.