From: Ralf Baechle <ralf@linux-mips.org>
To: Florian Fainelli <florian@openwrt.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: AR7: constify some arrays in gpio and prom code
Date: Fri, 4 Nov 2011 17:41:40 +0000 [thread overview]
Message-ID: <20111104174140.GA18965@linux-mips.org> (raw)
In-Reply-To: <1320427535-24351-1-git-send-email-florian@openwrt.org>
On Fri, Nov 04, 2011 at 06:25:35PM +0100, Florian Fainelli wrote:
> diff --git a/arch/mips/ar7/prom.c b/arch/mips/ar7/prom.c
> index 8088c6f..f642f64 100644
> --- a/arch/mips/ar7/prom.c
> +++ b/arch/mips/ar7/prom.c
> @@ -69,7 +69,7 @@ struct psbl_rec {
> u32 ffs_size;
> };
>
> -static __initdata char psp_env_version[] = "TIENV0.8";
> +static __initdata const char psp_env_version[] = "TIENV0.8";
Should be:
static const char psp_env_version[] __initconst = "TIENV0.8";
so psp_env_version actually ends up in a read-only section.
Ralf
prev parent reply other threads:[~2011-11-04 17:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 17:25 [PATCH] MIPS: AR7: constify some arrays in gpio and prom code Florian Fainelli
2011-11-04 17:41 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111104174140.GA18965@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.