From: Greg KH <greg@kroah.com>
To: Kim Phillips <kim.phillips@freescale.com>
Cc: David Miller <davem@davemloft.net>,
stable@vger.kernel.org, eric.dumazet@gmail.com,
zheng.z.yan@intel.com, netdev@vger.kernel.org,
David Ward <david.ward@ll.mit.edu>
Subject: Re: [stable] net: Handle different key sizes between address families in flow cache
Date: Fri, 4 Nov 2011 14:24:39 -0700 [thread overview]
Message-ID: <20111104212439.GA27324@kroah.com> (raw)
In-Reply-To: <20111104144659.3e0a30afffffd9dd73cf740e@freescale.com>
On Fri, Nov 04, 2011 at 02:46:59PM -0500, Kim Phillips wrote:
> commit aa1c366e4febc7f5c2b84958a2dd7cd70e28f9d0 upstream.
>
> With the conversion of struct flowi to a union of AF-specific structs, some
> operations on the flow cache need to account for the exact size of the key.
>
> Signed-off-by: David Ward <david.ward@ll.mit.edu>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Cc: stable@vger.kernel.org # v3.0.x
> ---
> This patch is the result of a clean cherry-pick onto v3.0.8.
> It restores IPSec fwding performance from ~4kpps back to ~44kpps on
> a P2020DS board.
Too bad you forgot to build this patch after you applied it:
CC init/main.o
In file included from include/linux/security.h:39:0,
from init/main.c:32:
include/net/flow.h: In function ‘flow_key_size’:
include/net/flow.h:174:3: error: size of unnamed array is negative
include/net/flow.h:177:3: error: size of unnamed array is negative
Please be kind to your poor over-worked stable kernel maintainer and do
the decent thing and TEST YOUR PATCH before you ask him to accept it.
bah, I think it's time for the weekend to start a bit earlier than normal...
greg k-h
next prev parent reply other threads:[~2011-11-04 21:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 7:58 [PATCH] ipv4: fix ipsec forward performance regression Yan, Zheng
2011-10-23 9:03 ` Eric Dumazet
2011-10-24 7:02 ` David Miller
2011-11-01 23:50 ` Kim Phillips
2011-11-02 0:34 ` David Miller
2011-11-03 18:58 ` Kim Phillips
2011-11-04 2:43 ` David Miller
2011-11-04 19:46 ` [stable] net: Handle different key sizes between address families in flow cache Kim Phillips
2011-11-04 20:41 ` David Miller
2011-11-04 21:24 ` Greg KH [this message]
2011-11-05 2:29 ` Kim Phillips
2011-11-08 16:53 ` Greg KH
2011-11-08 19:44 ` [stable v2] " Kim Phillips
2011-10-23 14:52 ` [PATCH] ipv4: fix ipsec forward performance regression Julian Anastasov
2011-10-24 0:41 ` Yan, Zheng
2011-10-24 7:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111104212439.GA27324@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=david.ward@ll.mit.edu \
--cc=eric.dumazet@gmail.com \
--cc=kim.phillips@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.