From: Chris Mason <chris.mason@oracle.com>
To: Josef Bacik <josef@redhat.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix delayed insertion reservations V2
Date: Sat, 5 Nov 2011 07:46:35 -0400 [thread overview]
Message-ID: <20111105114635.GB4253@shiny> (raw)
In-Reply-To: <20111105004756.GA4253@shiny>
On Fri, Nov 04, 2011 at 08:47:56PM -0400, Chris Mason wrote:
> On Fri, Nov 04, 2011 at 05:18:54PM -0400, Josef Bacik wrote:
> > V1->V2: I stupidly thought I could get away with some flushing if we needed
> > space but I was wrong, we could deadlock, so add a btrfs_add_bytes_noflush
> > variant that will not do any flushing and will just return ENOSPC which will let
> > us fallback and do our full flushing.
> > fs/btrfs/ctree.h | 3 +++
> > fs/btrfs/delayed-inode.c | 36 ++++++++++++++++++++++++++++--------
> > fs/btrfs/extent-tree.c | 18 ++++++++++++++++++
> > 3 files changed, 49 insertions(+), 8 deletions(-)
>
> This helps but it I've got a bunch of these in the log now:
>
> btrfs_dirty_inode: 205 callbacks suppressed
> btrfs: fail to dirty inode 1294 error -28
> btrfs: fail to dirty inode 1208 error -28
> btrfs: fail to dirty inode 714 error -28
> btrfs: fail to dirty inode 1772 error -28
> btrfs: fail to dirty inode 1389 error -28
> btrfs: fail to dirty inode 770 error -28
> btrfs: fail to dirty inode 345 error -28
> btrfs: fail to dirty inode 1533 error -28
> btrfs: fail to dirty inode 624 error -28
> btrfs: fail to dirty inode 1085 error -28
I should add this only seems to happen during xfstest 083.
-chris
next prev parent reply other threads:[~2011-11-05 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 21:18 [PATCH] Btrfs: fix delayed insertion reservations V2 Josef Bacik
2011-11-05 0:47 ` Chris Mason
2011-11-05 11:46 ` Chris Mason [this message]
2011-11-05 12:23 ` Mitch Harder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111105114635.GB4253@shiny \
--to=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.