From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] NAND: Let NAND_NO_SUBPAGE_WRITE through
Date: Sun, 6 Nov 2011 16:16:47 +0100 [thread overview]
Message-ID: <201111061616.47432.marek.vasut@gmail.com> (raw)
In-Reply-To: <4EB69FC0.2060500@denx.de>
> On 11/06/2011 01:43 PM, Marek Vasut wrote:
> > Yes sure, but the controller driver sets it as a chip option as there's
> > no "controller" option field and I don't want to introduce new
> > definition consuming one bit in the top half of chip option.
>
> Let's see how evolve the discussion - allowing to mix chip and
> controller options was
Exactly, I consider this patch more as a workaround, so figuring out a proper
solution would be awesome. Though I'm quite sure there is a bug in the MTD
layer.
>
> > No, the controller must set NAND_NO_SUBPAGE_WRITE as a chip option in its
> > driver to force it so it should work for both cases.
>
> As far as I remember (not very well, I admit..), the only way for the
> driver to set them was in the board_nand_init(), but these options are
> overwritten when the flash is detected, making NAND_NO_SUBPAGE_WRITE
> worthless. Am I wrong ?
>
This is what this patch works around ;-)
next prev parent reply other threads:[~2011-11-06 15:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-05 2:24 [U-Boot] [PATCH] NAND: Let NAND_NO_SUBPAGE_WRITE through Marek Vasut
2011-11-06 9:01 ` Stefano Babic
2011-11-06 12:43 ` Marek Vasut
2011-11-06 14:54 ` Stefano Babic
2011-11-06 15:16 ` Marek Vasut [this message]
2011-11-10 17:02 ` Marek Vasut
2011-11-10 17:10 ` Scott Wood
2011-11-10 17:44 ` Marek Vasut
2011-11-11 12:52 ` Veli-Pekka Peltola
2011-11-11 17:50 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111061616.47432.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.