From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: 075 112 redirect stderr of fsx to /dev/null too
Date: Mon, 7 Nov 2011 10:06:31 +1100 [thread overview]
Message-ID: <20111106230631.GD5534@dastard> (raw)
In-Reply-To: <1319941555-4405-1-git-send-email-guaneryu@gmail.com>
On Sun, Oct 30, 2011 at 10:25:55AM +0800, Eryu Guan wrote:
> In commit c18bf42de9d5d5fa05025754df1ff63f2147bd12 a warning message
> will be printed to stderr if filesystem doesn't support fallocate(2).
> The warning message will fail these tests though fsx returns SUCCESS.
>
> FSTYP -- ext3
> PLATFORM -- Linux/i686 debian-dev 3.1.0+
> MKFS_OPTIONS -- /dev/sda3
> MOUNT_OPTIONS -- -o acl,user_xattr /dev/sda3 /mnt/sda3
>
> 075 12s ... - output mismatch (see 075.out.bad)
> --- 075.out 2011-10-28 21:35:41.872573530 +0800
> +++ 075.out.bad 2011-10-30 10:31:02.607058029 +0800
> @@ -4,6 +4,9 @@
> -----------------------------------------------
> fsx.0 : -d -N numops -S 0
> -----------------------------------------------
> +fsx: main: filesystem does not support fallocate, disabling
> +: Operation not supported
>
> So redirect stderr of fsx to /dev/null too.
>
> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
> ---
> 075 | 2 +-
> 112 | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/075 b/075
> index 0f0a6ed..87d273f 100755
> --- a/075
> +++ b/075
> @@ -77,7 +77,7 @@ _do_test()
>
> # This cd and use of -P gets full debug on $here (not TEST_DEV)
> cd $out
> - if ! $here/ltp/fsx $_param -P $here $seq.$_n >/dev/null
> + if ! $here/ltp/fsx $_param -P $here $seq.$_n &>/dev/null
> then
> echo " fsx ($_param) failed, $? - compare $seq.$_n.{good,bad,fsxlog}"
> mv $out/$seq.$_n $here/$seq.$_n.full
> diff --git a/112 b/112
> index 557350a..763b17a 100755
> --- a/112
> +++ b/112
> @@ -77,7 +77,7 @@ _do_test()
>
> # This cd and use of -P gets full debug on $here (not TEST_DEV)
> cd $out
> - if ! $here/ltp/fsx $_param -P $here $seq.$_n >/dev/null
> + if ! $here/ltp/fsx $_param -P $here $seq.$_n &>/dev/null
> then
> echo " fsx ($_param) returned $? - see $seq.$_n.full"
> mv $seq.$_n.fsxlog $here/$seq.$_n.full
If this hasn't been committed, the correct fix is to pass the "-q"
option to fsx to tell it not to emit these messages. We still really
want any other output to stderr to cause a test failure....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-06 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-30 2:25 [PATCH] xfstests: 075 112 redirect stderr of fsx to /dev/null too Eryu Guan
2011-10-30 4:45 ` Christoph Hellwig
2011-11-06 23:06 ` Dave Chinner [this message]
2011-11-07 7:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111106230631.GD5534@dastard \
--to=david@fromorbit.com \
--cc=guaneryu@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.