From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org,
Mori Hess <fmhess@users.sourceforge.net>,
Ian Abbott <abbotti@mev.co.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] staging/comedi/jr3: Convert pci_table entries to PCI_DEVICE (if PCI_ANY_ID is used)
Date: Mon, 7 Nov 2011 08:51:00 +0300 [thread overview]
Message-ID: <20111107055100.GV4682@mwanda> (raw)
In-Reply-To: <1320623647-5108-1-git-send-email-peterhuewe@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Mon, Nov 07, 2011 at 12:53:59AM +0100, Peter Huewe wrote:
> This patch converts pci_table entries to use the PCI_DEVICE macro,
> if .subvendor and .subdevice are set to PCI_ANY_ID,
> and thus improves readablity.
>
> Since the driver_data field isn't used anywhere we can also drop the
> assignments for class, class_mask and driver_data.
>
The other reason we can remove them is that C will initialize them
to zero by default in this case. So the new code is just shorter to
write and doesn't change anything.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-11-07 5:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 23:53 [PATCH 1/9] staging/comedi/jr3: Convert pci_table entries to PCI_DEVICE (if PCI_ANY_ID is used) Peter Huewe
2011-11-06 23:54 ` [PATCH 2/9] staging/comedi/daqboard: " Peter Huewe
2011-11-06 23:54 ` [PATCH 3/9] staging/comedi/adl: " Peter Huewe
2011-11-06 23:54 ` [PATCH 4/9] staging/comedi/amplc: " Peter Huewe
2011-11-06 23:54 ` [PATCH 5/9] staging/comedi/cb_pcimdda: " Peter Huewe
2011-11-06 23:54 ` [PATCH 6/9] staging/comedi/das08: " Peter Huewe
2011-11-06 23:54 ` [PATCH 7/9] staging/comedi/ke_counter: " Peter Huewe
2011-11-06 23:54 ` [PATCH 8/9] staging/comedi/me_daq: " Peter Huewe
2011-11-06 23:54 ` [PATCH 9/9] staging/comedi/contec: " Peter Huewe
2011-11-07 5:51 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107055100.GV4682@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.